feat(codegen): slider support #29087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ruifigueira
force-pushed
the
feat/record-slider
branch
from
e441959
to
f65c4cb
Compare
This comment has been minimized.
This comment has been minimized.
ruifigueira
force-pushed
the
feat/record-slider
branch
from
f65c4cb
to
76820ed
Compare
This comment has been minimized.
This comment has been minimized.
ruifigueira
force-pushed
the
feat/record-slider
branch
2 times, most recently
from
a3bff1d
to
3da9702
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ruifigueira
force-pushed
the
feat/record-slider
branch
from
3da9702
to
b4d6ba8
Compare
This comment has been minimized.
This comment has been minimized.
packages/playwright-core/src/server/injected/recorder/recorder.ts
Outdated
Show resolved
Hide resolved
This handles scenarios where the current hovered element in recorder may not correspond to the event target. See: microsoft#29067 (comment)
ruifigueira
force-pushed
the
feat/record-slider
branch
from
b4d6ba8
to
a89eea6
Compare
Test results for "tests 1"1 failed 2 flaky21250 passed, 577 skipped Merge workflow run. |
pavelfeldman
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for range slider inputs.
It handles the special case of webkit, which triggers a click event with the body element as target when sliding the input element. For that reason, I skip the click handling event if the hovered element is a range input, without consuming it.
In my first approach (#28767) I was naive and assumed that click events should have the same target element as the current hovered element, and that caused the regression reported in #29067. Sorry about that 😔