Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(role): cache element list by role (#29130)" #29765

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Mar 1, 2024

This reverts commit 1ce3ca2.

Added a regression test.

Fixes #29760.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Test results for "tests 1"

6 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/interception.spec.ts:104:3 › should intercept network activity from worker
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26648 passed, 614 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit a8c26d2 into microsoft:main Mar 1, 2024
30 checks passed
dgozman added a commit that referenced this pull request Mar 1, 2024
Copy link

@KidiIT KidiIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reviewed and approved🫶❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Possible regression with chained locators in v1.42
3 participants