Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-mode): do not loose run information after writing into testDir #30312

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Apr 9, 2024

Partially reverts #30008 that started to reset all test results upon listing tests, including the test that did just run and triggered re-listing.

Fixes #30300.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-cdn.spec.ts:41:7 › playwright cdn failover should work (https://playwright.azureedge.net)

3 flaky ⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [webkit-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26943 passed, 619 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 15b4231 into microsoft:main Apr 10, 2024
29 of 30 checks passed
fungairino added a commit to pixiebrix/pixiebrix-extension that referenced this pull request Apr 10, 2024
Upgrade once this issue fix is released: microsoft/playwright#30312
fungairino added a commit to pixiebrix/pixiebrix-extension that referenced this pull request Apr 10, 2024
* Improve e2e test docs and error handling

* add more detail

* fix

* downgrade to 1.42.1

Upgrade once this issue fix is released: microsoft/playwright#30312
mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Apr 10, 2024
…ion after writing into testDir

Partially reverts microsoft#30008
that started to reset all test results upon listing tests, including the
test that did just run and triggered re-listing.

microsoft#30300.
mxschmitt added a commit that referenced this pull request Apr 11, 2024
… writing into testDir (#30328)

Partially reverts #30008
that started to reset all test results upon listing tests, including the
test that did just run and triggered re-listing.

#30300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION]: UI mode restarts if keep storage state
2 participants