Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try running audio/video tests on more browsers and platforms #30437

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −9
Open

Try running audio/video tests on more browsers and platforms #30437

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d28e9a
Try running audio/video tests everywhere
stephenwade Apr 19, 2024
f203624
Playing audio doesn't work in Webkit other than macOS
stephenwade Apr 20, 2024
364173f
Playing video doesn't work in Webkit on Windows
stephenwade Apr 21, 2024
dc06f1a
Skip flaky tests on macos-12
stephenwade Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 7 additions & 9 deletions tests/library/capabilities.spec.ts
View file
Open in desktop
Expand Up @@ -69,8 +69,7 @@ it('should play video @smoke', async ({ page, asset, browserName, platform, mode
// apparently due to a Media Pack issue in the Windows Server.
// Also the test is very flaky on Linux WebKit.
it.fixme(browserName === 'webkit' && platform !== 'darwin');
it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/5721');
it.fixme(browserName === 'webkit' && platform === 'darwin' && parseInt(os.release(), 10) === 20, 'Does not work on BigSur');
it.fixme(browserName === 'webkit' && platform === 'darwin' && parseInt(os.release(), 10) === 21, 'Flaky on macOS 12');
it.skip(mode.startsWith('service'));

// Safari only plays mp4 so we test WebKit with an .mp4 clip.
Expand All @@ -84,8 +83,7 @@ it('should play video @smoke', async ({ page, asset, browserName, platform, mode
});

it('should play webm video @smoke', async ({ page, asset, browserName, platform, mode }) => {
it.fixme(browserName === 'webkit' && platform === 'darwin' && parseInt(os.release(), 10) === 20, 'Does not work on BigSur');
it.fixme(browserName === 'webkit' && platform === 'win32');
it.fixme(browserName === 'webkit' && platform !== 'darwin');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this means it doesn't work on linux?

it.skip(mode.startsWith('service'));

const absolutePath = asset('video_webm.html');
Expand All @@ -97,9 +95,9 @@ it('should play webm video @smoke', async ({ page, asset, browserName, platform,
});

it('should play audio @smoke', async ({ page, server, browserName, platform }) => {
it.fixme(browserName === 'firefox' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/10887');
it.fixme(browserName === 'firefox' && platform === 'linux', 'https://github.com/microsoft/playwright/issues/10887');
it.fixme(browserName === 'webkit' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/10892');
it.fixme(browserName === 'webkit' && platform !== 'darwin');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't fixme on linux before?

lets try to stick with === rather than !== I think thats easier to read.

it.fixme(browserName === 'webkit' && platform === 'darwin' && parseInt(os.release(), 10) === 21, 'Flaky on macOS 12');

await page.goto(server.EMPTY_PAGE);
await page.setContent(`<audio src="${server.PREFIX}/example.mp3"></audio>`);
await page.$eval('audio', e => e.play());
Expand Down Expand Up @@ -131,8 +129,8 @@ it('should support webgl 2 @smoke', async ({ page, browserName, headless, isWind
});

it('should not crash on page with mp4 @smoke', async ({ page, server, platform, browserName }) => {
it.fixme(browserName === 'webkit' && platform === 'win32', 'https://github.com/microsoft/playwright/issues/11009, times out in setContent');
it.fixme(browserName === 'firefox', 'https://bugzilla.mozilla.org/show_bug.cgi?id=1697004');
it.fixme(browserName === 'webkit' && platform === 'win32', 'times out in setContent');

await page.setContent(`<video><source src="${server.PREFIX}/movie.mp4"/></video>`);
await page.waitForTimeout(1000);
});
Expand Down