Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#30800): Revert "fix(highlight): highlight Top Layer elements (#30001)" #30801

Merged
merged 1 commit into from
May 14, 2024

Conversation

playwrightmachine
Copy link
Collaborator

This PR cherry-picks the following commits:

@mxschmitt mxschmitt merged commit 01bf93c into release-1.44 May 14, 2024
88 of 97 checks passed
@mxschmitt mxschmitt deleted the cherry-pick-1.44-2024-05-14-16-25-06 branch May 14, 2024 17:00
Copy link
Contributor

Test results for "tests 1"

27279 passed, 671 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

4 fatal errors, not part of any test
12 failed
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [chromium-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [chromium-library] › library/capabilities.spec.ts:133:3 › should not crash on page with mp4 @smoke
❌ [firefox-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

50 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-page] › page/page-drag.spec.ts:397:3 › should handle custom dataTransfer
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [chromium-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:197:7 › cli codegen › should not target selector preview by text regexp
⚠️ [firefox-page] › page/page-event-request.spec.ts:171:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [firefox-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [firefox-page] › page/page-screenshot.spec.ts:662:5 › page screenshot animations › should resume infinite animations
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:46:3 › should click with disabled javascript
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:571:5 › launchServer › should be able to connect when the wsEndpoint is passed as an option
⚠️ [firefox-library] › library/capabilities.spec.ts:22:3 › SharedArrayBuffer should work @smoke
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:200:7 › cli codegen › should download files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox-library] › library/video.spec.ts:227:5 › screencast › saveAs should throw when no video frames
⚠️ [firefox-library] › library/video.spec.ts:330:5 › screencast › should expose video path blank popup
⚠️ [firefox-page] › page/page-click-scroll.spec.ts:55:3 › should scroll into view display:contents with a child
⚠️ [firefox-page] › page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup
⚠️ [chromium-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-page] › page/page-leaks.spec.ts:92:5 › fill should not leak
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:451:7 › cli codegen › should check
⚠️ [webkit-page] › page/page-click.spec.ts:1127:3 › should fire contextmenu event on right click in correct order
⚠️ [webkit-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:341:7 › cli codegen › should press
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:502:7 › cli codegen › should check with keyboard
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:415:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit-library] › library/inspector/cli-codegen-java.spec.ts:42:5 › should print the correct context options for custom settings
⚠️ [webkit-page] › page/page-request-continue.spec.ts:196:5 › post data › should compute content-length from post data
⚠️ [webkit-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [webkit-library] › library/browsercontext-device.spec.ts:45:5 › device › should scroll to click
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-page] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

168887 passed, 7573 skipped, 2678 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants