[Fabric] Move playground compositor to a background thread #12073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisglein
reviewed
Aug 25, 2023
packages/playground/windows/playground-composition/Playground-Composition.cpp
Show resolved
Hide resolved
packages/playground/windows/playground-composition/Playground-Composition.cpp
Outdated
Show resolved
Hide resolved
chrisglein
approved these changes
Aug 25, 2023
|
Converting to draft for now. Not sure that this is the direction I want to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Office runs its compositor on a background thread.
With this change, the playground-composition app will too. Either should work, but this makes the default the more complex case and will help with future additions that will add test cases that cause issues with the current fabric implementation.
Why
There are currently issues when fabric attempts to draw to the compositor tree at the same time as a composition commit is happening from a background thread. This is a first step in properly creating a reproduction of this in RNW.
Microsoft Reviewers: Open in CodeFlow