Implement BlobCollector #12269
Merged
Implement BlobCollector #12269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
approved these changes
Oct 20, 2023
JunielKatarn
added a commit
that referenced
this pull request
Oct 20, 2023
* Implement BlobCollector * Change files * clang format
This was referenced Oct 20, 2023
JunielKatarn
added a commit
that referenced
this pull request
Oct 20, 2023
* Implement BlobCollector * Change files * clang format
JunielKatarn
added a commit
that referenced
this pull request
Oct 20, 2023
* Implement BlobCollector * Change files * clang format
JunielKatarn
added a commit
that referenced
this pull request
Oct 21, 2023
* Implement BlobCollector (#12269) * Implement BlobCollector * Change files * clang format * Remove change files * Change files
JunielKatarn
added a commit
that referenced
this pull request
Oct 21, 2023
* Implement BlobCollector (#12269) * Implement BlobCollector * Change files * clang format * Remove change files * Change files
JunielKatarn
added a commit
that referenced
this pull request
Oct 21, 2023
* Implement BlobCollector (#12269) * Implement BlobCollector * Change files * clang format * Remove change files * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows disposing of unused Blob data when JS garbage collection takes place.
Type of Change
Why
Continuous instantiation of
BlobJavaScript objects can lead to memory leaks because the disposal of those objects does not trigger the deallocation of the blob data on the native side (seeIBlobPersistor).For further context:
fetchmore than a certain number of times in React Native facebook/react-native#39441What
Microsoft::React::BlobCollector.Blobinstance lifetime and cleans up its corresponding blob data on destruction.__blobCollectorProviderthrough JSI.Important: This fix only applies to the TurboModule variant.
We need to figure out a way to set this up for the Blob CxxModule, which requires accessing its
facebook::jsi::Runtimeinstance reference.Testing
Use proof of concept https://github.com/jurocha-ms/Repro/tree/blobmemleak/ReactNative/fetchwinleak (see README).
Microsoft Reviewers: Open in CodeFlow