New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prettier-plugin-hermes-parser to match upstream settings #12599
base: main
Are you sure you want to change the base?
Conversation
e45ddaa
to
0239bc3
Compare
In order to minimize the delta between platform override files in react-native-windows and upstream facebook/react-native files, switch to prettier-plugin-hermes-parser. The same change was made in facebook/react-native@dc2037c
@@ -88,7 +88,7 @@ const backgroundForLevel = (level: LogLevel) => | |||
default: 'transparent', | |||
pressed: LogBoxStyle.getFatalDarkColor(), | |||
}, | |||
}[level]); | |||
})[level]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you need to apply this change to packages\@office-iss\react-native-win32\src\Libraries\LogBox\UI\LogBoxInspectorHeader.win32.js
in order to pass linting.
Change is approved. Will merge when CI runs green. |
@rozele PR has signoff but needs a clean CI run. With that, good to go. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Description
What
In order to minimize the delta between platform override files in react-native-windows and upstream facebook/react-native files, switch to prettier-plugin-hermes-parser. The same change was made in facebook/react-native@dc2037c
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow