-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorts imports and fixes modernizes types for Flyout component #12601
base: main
Are you sure you want to change the base?
Conversation
Makes a few minor adjustments to Flyout.js and FlyoutNativeComponents.js to satisfy a few stricter flow and lint checks.
@@ -3,14 +3,13 @@ | |||
* Licensed under the MIT License. | |||
* @format | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this/below have an @flow strict
or @flow strict-local
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably?
Change is approved. Will merge when CI runs green. |
@rozele This PR is older but had signoff pending a clean CI. If you can get that running clean, seems good to go? |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Why
Makes a few minor adjustments to Flyout.js and FlyoutNativeComponents.js to satisfy a few stricter flow and lint checks.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow