Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): gradle/actions/setup-gradle is for setup only #3122

Merged
merged 1 commit into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-planets-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rnx-kit/build": patch
---

Using `gradle/actions/setup-gradle` to execute Gradle is deprecated (see https://github.com/gradle/actions/blob/v3/docs/deprecation-upgrade-guide.md#using-the-action-to-execute-gradle-via-the-arguments-parameter-is-deprecated)
16 changes: 7 additions & 9 deletions .github/workflows/rnx-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,16 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: android
cache-npm-dependencies: ${{ github.event.inputs.packageManager }}
- name: Install npm dependencies
run: ${{ github.event.inputs.packageManager }} install
- name: Build Android app
uses: gradle/actions/setup-gradle@v3
with:
gradle-version: wrapper
arguments: --no-daemon clean assembleDebug
build-root-directory: ${{ github.event.inputs.projectRoot }}/android
run: ./gradlew --no-daemon clean assembleDebug
shell: bash
working-directory: ${{ github.event.inputs.projectRoot }}/android
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
Expand All @@ -68,7 +66,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: ios
project-root: ${{ github.event.inputs.projectRoot }}
Expand Down Expand Up @@ -122,7 +120,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: macos
project-root: ${{ github.event.inputs.projectRoot }}
Expand Down Expand Up @@ -156,7 +154,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: windows
cache-npm-dependencies: ${{ github.event.inputs.packageManager }}
Expand Down
16 changes: 7 additions & 9 deletions incubator/build/workflows/github.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,16 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: android
cache-npm-dependencies: ${{ github.event.inputs.packageManager }}
- name: Install npm dependencies
run: ${{ github.event.inputs.packageManager }} install
- name: Build Android app
uses: gradle/actions/setup-gradle@v3
with:
gradle-version: wrapper
arguments: --no-daemon clean assembleDebug
build-root-directory: ${{ github.event.inputs.projectRoot }}/android
run: ./gradlew --no-daemon clean assembleDebug
shell: bash
working-directory: ${{ github.event.inputs.projectRoot }}/android
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
Expand All @@ -68,7 +66,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: ios
project-root: ${{ github.event.inputs.projectRoot }}
Expand Down Expand Up @@ -122,7 +120,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: macos
project-root: ${{ github.event.inputs.projectRoot }}
Expand Down Expand Up @@ -156,7 +154,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up toolchain
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.13
uses: microsoft/react-native-test-app/.github/actions/setup-toolchain@3.5.15
with:
platform: windows
cache-npm-dependencies: ${{ github.event.inputs.packageManager }}
Expand Down