Skip to content

Commit

Permalink
Merge pull request #4463 from microsoft/octogonz/rush-missing-experiment
Browse files Browse the repository at this point in the history
[rush] Update "rush init" template to document missing experiment
  • Loading branch information
octogonz committed Dec 23, 2023
2 parents 2d96034 + 21ee982 commit 2c8bed2
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/main_2023-12-23-05-43.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Update `rush init` template to document the \"buildSkipWithAllowWarningsInSuccessfulBuild\" experiment",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@
*/
/*[LINE "HYPOTHETICAL"]*/ "buildCacheWithAllowWarningsInSuccessfulBuild": true,

/**
* If true, build skipping will respect the allowWarningsInSuccessfulBuild flag and skip builds with warnings.
* This will not replay warnings from the skipped build.
*/
/*[LINE "HYPOTHETICAL"]*/ "buildSkipWithAllowWarningsInSuccessfulBuild": true,

/**
* If true, the phased commands feature is enabled. To use this feature, create a "phased" command
* in common/config/rush/command-line.json.
Expand Down
4 changes: 2 additions & 2 deletions libraries/rush-lib/src/api/ExperimentsConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ import schemaJson from '../schemas/experiments.schema.json';
export interface IExperimentsJson {
/**
* By default, 'rush install' passes --no-prefer-frozen-lockfile to 'pnpm install'.
* Set this option to true to pass '--frozen-lockfile' instead.
* Set this option to true to pass '--frozen-lockfile' instead for faster installs.
*/
usePnpmFrozenLockfileForRushInstall?: boolean;

/**
* By default, 'rush update' passes --no-prefer-frozen-lockfile to 'pnpm install'.
* Set this option to true to pass '--prefer-frozen-lockfile' instead.
* Set this option to true to pass '--prefer-frozen-lockfile' instead to minimize shrinkwrap changes.
*/
usePnpmPreferFrozenLockfileForRushUpdate?: boolean;

Expand Down

0 comments on commit 2c8bed2

Please sign in to comment.