Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extractor] #3465 incorrectly changed defaults for reportFolder in the template #4543

Open
mcdurdin opened this issue Feb 26, 2024 · 2 comments

Comments

@mcdurdin
Copy link

Summary

The default for reportFolder is etc:

"reportFolder": "<projectFolder>/etc/",

The change in #3465 changed this to temp. This is wrong, and it makes the template comments confusing, because the temp folder should not be committed to git. The report file is written to both temp and etc on first run.

Details

#3465 should be rolled back.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/api-extractor version? 7.41.0
Operating system? Windows
API Extractor scenario? reporting
Would you consider contributing a PR? Yes
TypeScript compiler version? 4.9.5 / 5.3.3
Node.js version (node -v)? 18.14.1
@iclanton
Copy link
Member

@octogonz - Which should be correct here?

@atdyer
Copy link

atdyer commented Apr 3, 2024

Hi all, just chiming in here because I stumbled on this in a new project I created. @mcdurdin is correct that the change made in #3465 is wrong and the PR should be rolled back.

The default value as specified in the defaults is "<projectFolder>/etc/", see in code here.

I suspect the confusion is coming from the fact that running api-extractor without the --local flag will only write the .api.md file to the reportTempFolder, which by default is "<projectFolder>/temp/". Including the --local flag will write the file to both folders. This behavior is described in the API report documentation, found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: AE/AD
Development

No branches or pull requests

3 participants