[api-extractor] Fix wrongly documented default path for reportFolder #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alirezamirian
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
|
Can you run |
.api.md file is generated in `temp` folder by default, not `etc`
|
|
iclanton
reviewed
Jun 15, 2022
common/changes/@microsoft/api-extractor/patch-1_2022-06-13-19-22.json
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
Jun 15, 2022
|
This change seems incorrect. The default for reportFolder is It makes the template comments confusing, because the The report file is written to both temp and etc on first run. I think this change should be rolled back. (Note: made this into an issue in #4543) |
octogonz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.api.md file is generated in
tempfolder by default, notetcSummary
.api.mdfile is generated intempfolder by default, notetcDetails
N/A
How it was tested
I just ran api-extractor with default configuration and it created the report file in
tempfolder.