Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/introduce rust repo support #3961

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Feb 8, 2023

This PR introduces a heft-napi-rs-plugin in addition to a rust/hello-world directory managed by rush and the aforementioned plugin. In addition .gitignore has been updated to filter /target folder which Rust and rust tooling integrations use for incremental build cache. For now, this PR will simply introduce Rust and the heft plugin to the monorepo, and not have a publishing process. This will allow us to experiment with writing integrations in Rust, and require/importing them in our other packages for benchmarking, usability testing.

  • heft-napi-rs-plugin
    • Properly handle child_process.spawn()
    • Errors fail a build from rush build --to .
    • Errors output correctly in local build feedback
    • Rust Warnings show as Warnings and not Errors
    • Rust Output shows as Debug output and not Errors
    • Conditionally passing --release flag into cargo based on production mode
  • rust/hello-world
  • Run README.md scripts for new packages
  • Add README updates for links to Rust toolchain installation instructions
  • Have fail fast detection for rust toolchain not being already installed.

Second Iteration Work:

@TheLarkInn TheLarkInn force-pushed the feature/introduce-rust-repo-support branch from e85f022 to 300ceee Compare February 10, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Bug Triage
  
In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants