-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-documenter] Emit HTML tags for tables instead of Markdown code. #4578
Conversation
Nevermind, forgot to build before updating the tests again. |
apps/api-documenter/src/markdown/test/__snapshots__/CustomMarkdownEmitter.test.ts.snap
Outdated
Show resolved
Hide resolved
common/changes/@microsoft/api-documenter/main_2024-03-14-17-16.json
Outdated
Show resolved
Hide resolved
….json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
This PR introduces a regression. Opened #4586. |
👉 Please reply to issue #4586 |
* start documenting all exports * adjust integration tests to new inheritance * more docs * build docs to GitHub pages * more docs * forgot comment * drop HTML/deploy to GH pages * add docs markdown * changes by patched api-documenter * add patch to @microsoft/api-documenter see microsoft/rushstack#4578 * update links * remove repeated config * fix up error message * pin api-documenter version * code review
Summary
This would fix #2950.
Currently, tables in generated Markdown do not work with multiline comments.
This PR changes over to HTML tables (which also work in Markdown and are in fact more standardized).
As a result, a lot of "emit different things in tables" code can be removed.
Details
As an example of a broken generated table, see the end of the "Classes" table in this markdown file
How it was tested
Generating the code with this PR instead will result in this diff and as you can see here the tables are not broken anymore.
Impacted documentation
I believe this does not need any documentation changes.