Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Misc fixes for Rush subspaces #4692

Merged
merged 6 commits into from
May 10, 2024
Merged

[rush] Misc fixes for Rush subspaces #4692

merged 6 commits into from
May 10, 2024

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented May 10, 2024

Summary

While working on the Rush subspaces website docs, I found a few issues.

Details

  1. If you set subspacesFeatureEnabled=true but are missing common/config/rush/pnpm-config.json then you get extremely confusing error messages such as this:

    Installing for subspace: default
    
    Project filtering arguments can only be used when running in a workspace 
    environment. Run the command again without specifying these arguments.
    

    The reason is that it is a completely untested code path.

    @william2958 This situation is further compounded when common/config/rush/pnpm-config.json is missing, because useWorkspaces defaults to false and is completely ignored in files such as common/subspaces/my-subspace/pnpm-config.json. We need to design a better inheritance model for pnpm-config.json.

  2. Further simplify FlagFile internal API.

  3. Fix some typos in config files.

  4. Add rush init docs for subspaceName

How it was tested

Reproduced using rush-example repo.

@octogonz octogonz merged commit 1cb0e96 into main May 10, 2024
5 checks passed
@octogonz octogonz deleted the octogonz/misc-fixes branch May 10, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants