[rush] Misc fixes for Rush subspaces #4692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on the Rush subspaces website docs, I found a few issues.
Details
If you set
subspacesFeatureEnabled=true
but are missing common/config/rush/pnpm-config.json then you get extremely confusing error messages such as this:The reason is that it is a completely untested code path.
@william2958 This situation is further compounded when common/config/rush/pnpm-config.json is missing, because
useWorkspaces
defaults tofalse
and is completely ignored in files such as common/subspaces/my-subspace/pnpm-config.json. We need to design a better inheritance model for pnpm-config.json.Further simplify
FlagFile
internal API.Fix some typos in config files.
Add
rush init
docs forsubspaceName
How it was tested
Reproduced using
rush-example
repo.