Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] fix additionalProjectsToInclude field didn't work in rush deploy #4693

Merged
merged 3 commits into from
May 10, 2024

Conversation

EscapeB
Copy link
Contributor

@EscapeB EscapeB commented May 10, 2024

Summary

Fix issue reported in #4683

Details

Remove filtering logic in libraries/rush-lib/src/cli/actions/DeployAction.ts

In previous implementation, we used _getDependencyProjects() to filter a subset of projects and subspaces to be analyzed in PackageExtractor, it's an optimization in order to make the extract process more efficient.

Remove this filtering logic will pass all projects and all subspaces to PackageExtractor.

How it was tested

Tested with demo subspace repo https://github.com/william2958/rush-subspace-demo
eecc753f-14fc-4f02-9b02-06409aba866c

Final deploy structure
image

Impacted documentation

@octogonz octogonz changed the title fix: fix additionalProjectsToInclude field didn't work in rush deploy [rush] fix additionalProjectsToInclude field didn't work in rush deploy May 10, 2024
@octogonz octogonz merged commit dfb13d8 into microsoft:main May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants