[eslint-bulk] Fix #4691. #4694
Merged
[eslint-bulk] Fix #4691. #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
force-pushed
the
fix-eslint-bulk-escaping
branch
from
d104339
to
3a5cce4
Compare
D4N14L
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4691.
Details
This change runs a resolved eslint with
spawnSyncinstead ofexecSync, and wrap the eslintrc path in quotes.How it was tested
Built the
eslint-bulk-suppressions-testproject in a clone of this repo with a space in the path.