[lockfile-explorer] fix: exit with 0 for lockfile-explorer --help
#4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harttle
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
reviewed
May 15, 2024
common/changes/@rushstack/lockfile-explorer/fix-lockfile-explorer-cli_2024-05-15-07-23.json
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
May 15, 2024
…e-explorer-cli_2024-05-15-07-23.json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
iclanton
changed the title
lockfile-explorer --helplockfile-explorer --help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a bugfix for
lockfile-explorer --helpnot exiting with 0 code.Details
How it was tested
Added a
.test.tsfor the args parser, but not covering exitCode (it's a global status belong thestart.tswhich is harder to be tested).Impacted documentation
No doc to be updated as it's a bugfix.