[rush-lib] Fix an edge case for pnpm-sync where .pnpm folder is not exist but it is still a valid pnpm install #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-chao
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
octogonz
reviewed
May 16, 2024
common/changes/@microsoft/rush/chao-fix-edge-case_2024-05-16-00-22.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
May 16, 2024
libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts
Outdated
Show resolved
Hide resolved
octogonz
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When there is no any dependencies in a
package.json, thepnpm installwill only generate thepnpm-lock.yaml, but not.pnpmfolder.Add existence check for
pnpm-lock.yamlfile and.pnpmfolder before calling pnpm-sync APIsHow it was tested
Tested with Rushstack repos manually.
Impacted documentation
N/A