Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all dependencies on the "rimraf" library #928

Merged
merged 4 commits into from Nov 2, 2018
Merged

Remove all dependencies on the "rimraf" library #928

merged 4 commits into from Nov 2, 2018

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Nov 2, 2018

We don't need rimraf any more, since node-core-library provides equivalent functionality. It's based on fs-extra which is a slightly leaner and faster implementation than what rimraf does.

This is the first step towards fixing this annoying occasional error on Windows:

ERROR: ENOTEMPTY: directory not empty, rmdir 'C:\Some\Folder'
Often this is caused by a file lock from a process such as your text editor, command prompt, or "gulp serve"

The upstream fix is in jprichardson/node-fs-extra#646

iclanton
iclanton approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@iclanton iclanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@octogonz octogonz merged commit ac03c77 into master Nov 2, 2018
@octogonz octogonz deleted the pgonzal/delete-rimraf branch November 2, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclanton iclanton iclanton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@octogonz @iclanton @pgonzal