WIP: BatchIt #637
WIP: BatchIt #637
Conversation
nwf-msr
force-pushed
the
202309-msgpass
branch
4 times, most recently
from
8debce9
to
a26a036
Compare
|
Looks like it is leaking in some case |
nwf-msr
force-pushed
the
202309-msgpass
branch
2 times, most recently
from
81147f0
to
998c2f4
Compare
Whoops; I had the loop termination conditions wrong. They're fixed now, I think. Let's see if CI agrees. |
nwf-msr
force-pushed
the
202309-msgpass
branch
from
998c2f4
to
a145509
Compare
|
After discussions with @mjp41 yesterday, I've introduced a notion of "tweakable obfuscation" and have made all the intra-slab free lists' backwards signatures use the address of the slab metadata as the "tweak". The next step would be to remove the per-thread keys and have everyone use a common global key (probably not |
nwf-msr
force-pushed
the
202309-msgpass
branch
2 times, most recently
from
45dce78
to
86683a0
Compare
nwf-msr
force-pushed
the
202309-msgpass
branch
from
86683a0
to
6f4097c
Compare
|
I've (at long last) got things flying end to end with a very simple "cache" on the sending side -- a single open ring -- but I think some review and investigation is a good idea. Here's what |
nwf-msr
force-pushed
the
202309-msgpass
branch
6 times, most recently
from
b6ae5fc
to
769809d
Compare
The sizeclass was already testing most of this, so just add the missing bits. Forgo some tests whose failure would have implied earlier failures. This moves the last dynamic call of size_to_sizeclass_const into tests (and so, too, to_exp_mant_const). sizeclasstable.h still contains a static call to compute NUM_SMALL_SIZECLASSES from MAX_SMALL_SIZECLASS_SIZE.
Only its _const sibling is used, and little at that, now that almost everything to do with sizes and size classes is table-driven.
This just means I don't need to remember to set a breakpoint on exit
- Trace "Handling remote" once per batch, rather than per element - Remote queue events also log the associated metaslab; we'll use this to assess the efficacy of microsoft#634
Approximate a message-passing application as a set of producers, a set of consumers, and a set of proxies that do both. We'll use this for some initial insight for microsoft#634 but it seems worth having in general.
We'll use these to pack values in message queues. - Maximum distance between two objects in a single slab - Maximum number of objects in a slab
We'll use the _slower form when we're just stepping a slab through multiple rounds of state transition (to come), which can't involve the actual memory object in question.
The pattern of `if (!fast()) { slow() }` occurs in a few places, including in
contexts where we already know the entry and so don't need to look it up.
Plumb its use around remoteallocator and remotecache
This prepares the recipient to process a batched message.
Exercise recipient machinery by having the senders collect adjacent frees to the same slab into a batch.
This might involve multiple (I think at most two, at the moment) transitions in the slab lifecycle state machine. Towards that end, return indicators to the caller that the slow path must be taken and how many objects of the original set have not yet been counted as returned.
We can, as Matt so kindly reminds me, go get them from the pagemap. Since we need this value only when closing a ring, the read from over there is probably not very onerous. (We could also get the slab pointer from an object in the ring, but we need that whenever inserting into the cache, so it's probably more sensible to store that locally?)
As part of the assessment of #634, but also perhaps more generally useful. Opinions welcome.