Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: github/morello: catch up to 2023.11 #653

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nwf-msr
Copy link
Contributor

@nwf-msr nwf-msr commented Jan 4, 2024

The 2023.11 ports tree no longer has llvm-localbase depend on llvm, so go ahead and install that too.

CI on this PR will make sure that it still works with 2022.12, and I'll go manually test that it works on 2023.11, too.

@nwf-msr nwf-msr requested a review from mjp41 January 4, 2024 21:39
@nwf-msr nwf-msr force-pushed the 202401-morello-workflow-llvm branch from ccbf21f to bfd9633 Compare January 4, 2024 21:47
@nwf-msr
Copy link
Contributor Author

nwf-msr commented Jan 4, 2024

Ah, well, so much for easy. CheriBSD 2023.11 does not expose old jemalloc experimental API symbols (specifically allocm, nallocm, sallocm, dallocm, rallocm). (If you want the actual failure, it's over at https://github.com/microsoft/snmalloc/actions/runs/7415212980/job/20177910989 .) Jess conveys that they have even been removed from upstream jemalloc and are kept by FreeBSD for compatibility. How should we proceed?

Tagging @davidchisnall for opinions.

@davidchisnall
Copy link
Collaborator

FreeBSD has backports of them because someone thought it was a good idea to make them part of the libc API. I added them in snmalloc so that my snmalloc-in-libc branch can be ABI preserving. I’m not sure why CheriBSD removed them, since I’m not sure upstream FreeBSD has that option without a libc SONAME bump (which no one wants) and doesn’t need to do it (since we have compat implementations).

The test is toggled by this line:

We run it against libc on FreeBSD to make sure that our implementations of their APIs have the same behaviour as libc. We probably need an option to disable that if CheriBSD is happy breaking ABIs.

The 2023.11 ports tree no longer has llvm-localbase depend on llvm,
so go ahead and install that too.
@nwf-msr nwf-msr force-pushed the 202401-morello-workflow-llvm branch from dc2b97e to a85d0ef Compare January 5, 2024 18:07
@nwf-msr
Copy link
Contributor Author

nwf-msr commented Jan 5, 2024

Bah. The easy thing doesn't seem to have worked.
https://github.com/microsoft/snmalloc/actions/runs/7425654462/job/20207760770

@nwf-msr nwf-msr changed the title github/morello: also explicitly install llvm DNM: github/morello: catch up to 2023.11 Jan 5, 2024
@nwf-msr nwf-msr marked this pull request as draft May 24, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants