-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CmdLineArgs] "--keepOpen" to keep the window/tab/pane open after the process/profile has exited. #16497
base: main
Are you sure you want to change the base?
[CmdLineArgs] "--keepOpen" to keep the window/tab/pane open after the process/profile has exited. #16497
Changes from 6 commits
aece58f
8c2490e
ba5564b
fb530c5
9d6078a
2621322
6fe6d21
ee97500
21d0fc3
a25eef0
4241103
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -190,6 +190,11 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation | |||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||
defaultSettings.ReloadEnvironmentVariables(newTerminalArgs.ReloadEnvironmentVariables().Value()); | ||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
if (newTerminalArgs.KeepOpen()) | ||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||
// defaultSettings.CloseOnExit = CloseOnExitMode::Never; | ||||||||||||||||||||||||||||||||||||||
zadjii-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
return settingsPair; | ||||||||||||||||||||||||||||||||||||||
|
@@ -341,6 +346,8 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation | |||||||||||||||||||||||||||||||||||||
_RepositionCursorWithMouse = profile.RepositionCursorWithMouse(); | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
_ReloadEnvironmentVariables = profile.ReloadEnvironmentVariables(); | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
_CloseOnExit = profile.CloseOnExit(); | ||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this seems... weird. This should already be plumbed through to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, right. It's not actually used by the terminal/src/cascadia/TerminalApp/TerminalPaneContent.cpp Lines 240 to 256 in 9c16c5c
Looks like that's specifically looking up the CloseOnExit value out of the profile, not the This code has an example in that file of getting settings from the cache:
That'll get you a |
||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
// Method Description: | ||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct that this json code and the one in line 395 is used to read form/write to a WT arguments json file? Do I need to update a json schema? (I can't find one.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's pretty much it. The schema can be found at
terminal/doc/cascadia /profiles.schema.json