Remove __module__ hacks #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datamodules
|
These hacks were originally introduced to work around a bug in Sphinx 3. Now that PyTorch, TorchGeo, and torchvision all use Sphinx 4+, they are no longer needed. See sphinx-doc/sphinx#9395 for details. |
adamjstewart
commented
Dec 25, 2022
Comment on lines
+273
to
+274
| #: When :attr:`~RasterDataset.separate_files` is True, the following additional | ||
| #: groups are searched for to find other files: |
There was a problem hiding this comment.
This was referenced Dec 25, 2022
Closed
isaaccorley
approved these changes
Dec 26, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Remove __module__ hacks * Remove unused imports * Fix typo in reference * Explicit link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pickling of
torchgeo.trainersobjects and the vast majority of our documentation issues!See #886 and #101
Reboot of #317, #401, and #637. Fourth time's the charm!