Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update private class element helpers #146

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

mkubilayk
Copy link
Contributor

@mkubilayk mkubilayk commented Mar 23, 2021

A companion to microsoft/TypeScript#42458 - this PR updates __classPrivateFieldGet and __classPrivateFieldSet helpers to support private instance methods and accessors, and private static elements.

cc: @rbuckton

@rbuckton rbuckton merged commit 145fdc0 into microsoft:master Mar 25, 2021
@rbuckton
Copy link
Member

@DanielRosenwasser we will need to ship a new tslib to support microsoft/TypeScript#42458

@rbuckton
Copy link
Member

rbuckton commented Apr 3, 2021

@DanielRosenwasser can you publish a new tslib?

bors bot added a commit to foosbyte/kicker-trainer that referenced this pull request Oct 19, 2021
1440: fix: update dependency tslib to v2.3.1 (master) r=renovate[bot] a=renovate[bot]

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [tslib](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/tslib)) | [`2.1.0` -> `2.3.1`](https://renovatebot.com/diffs/npm/tslib/2.1.0/2.3.1) | [![age](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/compatibility-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/tslib/2.3.1/confidence-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>Microsoft/tslib</summary>

### [`v2.3.1`](https://togithub.com/Microsoft/tslib/releases/2.3.1)

[Compare Source](https://togithub.com/Microsoft/tslib/compare/2.3.0...2.3.1)

This release updates the `__spreadArray` helper for TypeScript 4.4 to correctly operate on collections that are not "concat-spreadable" such as the DOM's `NodeList`s and `HTMLCollection`s.

### [`v2.3.0`](https://togithub.com/Microsoft/tslib/releases/2.3.0)

[Compare Source](https://togithub.com/Microsoft/tslib/compare/2.2.0...2.3.0)

This release updates tslib to use TypeScript 4.4's upcoming `__spreadArray` helper which correctly preserves sparse array inputs (e.g. arrays containing "missing" elements like `[1, 2, , 4]`). This new version of `__spreadArray` is backwards-compatible and is often also faster. See [microsoft/tslib#151 for more details.

### [`v2.2.0`](https://togithub.com/Microsoft/tslib/releases/2.2.0)

[Compare Source](https://togithub.com/Microsoft/tslib/compare/2.1.0...2.2.0)

This release supports TypeScript 4.3's new functionality for ECMAScript private methods and accessors, and private static class members.

It does so by expanding the scope of `__classPrivateFieldGet` and `__classPrivateFieldSet`. See [microsoft/tslib#146 for more details.

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/foosbyte/kicker-trainer).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants