Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: set minimal permissions for GitHub Workflows #218

Merged
merged 1 commit into from
Aug 28, 2023
Merged

CI: set minimal permissions for GitHub Workflows #218

merged 1 commit into from
Aug 28, 2023

Conversation

diogoteles08
Copy link
Contributor

Closes #197

@diogoteles08
ci(github-workflows): add minimal permissions
6dbc352 
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
@diogoteles08
Copy link
Contributor Author

@microsoft-github-policy-service agree

jakebailey
jakebailey approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me; we have these same perms set on the TypeScript repo including the nightly publish step there, so I think this is safe.

@jakebailey jakebailey merged commit b1026e3 into microsoft:main Aug 28, 2023
6 checks passed
@diogoteles08 diogoteles08 mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: set minimal permissions for GitHub Workflows
2 participants
@diogoteles08 @jakebailey