Fix __asyncGenerator to properly handle AsyncGeneratorUnwrapYieldResumption #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why, but it seems like CodeQL is busted. |
|
The workflow is old and needs to be updated; I'll send a PR. |
|
#223 fixes it. |
rbuckton
force-pushed
the
fix-asyncGenerator-return
branch
from
4622d2d
to
1ed24c2
Compare
|
Well, CodeQL isn't erroring, but it isn't doing anything either. Is that expected?
|
|
That is... strange. I'll try and see what's happening. The path I used in the config is correct so I don't know what happened. |
jakebailey
approved these changes
Oct 20, 2023
|
I think that might be a leftover; the message mentions |
|
Or not... https://github.com/microsoft/tslib/pull/224/checks?check_run_id=17910983224 In any case, this PR looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same fix from microsoft/TypeScript#56150.