This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Handle TS exceptions in no-string-based-x rules #860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
New feature,bugfix,or enhancementOverview of change:
This PR does two things:
typeChecker.getTypeAtLocation
intry..catch
and restores same behavir when type checker is not available.This PR doesn't fix root cause of #859 but at least rules won't throw an exception.
Is there anything you'd like reviewers to focus on?
No unit tests for specific case because issue is noticeable in only in Vue. Should I add tests to handle this exceptional case?