This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
test-runner now shells one node for each dtslint #605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses the new, local test-worker, which just calls cp.exec(node dtslint) for each dtslint, instead of reusing the same dtslint over and over again. lodash and reactstrap still run out of memory, but they do that for individual calls to dtslint as well. I think multi-Typescript compiles in ExpectRule may need the same out-of-proc treatment.
|
Actually, when I think about it, only lodash and react are seeing oomemory crashes on CI. lodash itself runs out of memory and reactstrap depends on react. So I think the root cause is 3.4+ running out of memory on lodash and reactstrap. This PR isn't really needed. |
|
Filed microsoft/TypeScript#30973 to track this instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the new, local test-worker, which just calls cp.exec(node dtslint) for each dtslint, instead of reusing the same dtslint over and over again.
lodash and reactstrap still run out of memory, but they do that for individual calls to dtslint as well. I think multi-Typescript compiles in ExpectRule may need the same out-of-proc treatment.
Edit: No, types/lodash and types/reactstrap also run out of memory when just compiling with ts 3.4.