Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set disableLineTextInReferences=true in TS user preferences #92

Merged
merged 1 commit into from Jan 17, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Jan 15, 2023

I sent microsoft/vscode#171376 to enable this option in VS Code; we should match it here.

This should get rid of a lot of the annoying false positive error deltas on PRs.

ref microsoft/TypeScript#51017 and microsoft/TypeScript#51081

@jakebailey
Copy link
Member Author

Noticed that this option was flipped in #89, so not sure what happened there.

@amcasey
Copy link
Member

amcasey commented Jan 17, 2023

Noticed that this option was flipped in #89, so not sure what happened there.

I'm guessing that was for local testing and didn't get reverted before merging.

@jakebailey jakebailey merged commit 5edba92 into microsoft:main Jan 17, 2023
@jakebailey jakebailey deleted the disableLineTextInReferences branch January 17, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants