Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating OpenAPI3 emitter to sort response header in Lexicographic order #3015

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

allenjzhang
Copy link
Member

@allenjzhang allenjzhang commented Mar 13, 2024

No description provided.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 13, 2024

All changed packages have been documented.

@allenjzhang allenjzhang changed the title Updating OpenAPI3 emitter to sort response header in lexical order Updating OpenAPI3 emitter to sort response header in Lexicographic order Mar 13, 2024
@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3015/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3015/

Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do sorting here at all and if we did we should do the same as autorest emitter with a schema to define the whole order.

@allenjzhang allenjzhang marked this pull request as draft March 14, 2024 04:37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should not making this a reusable package as we need this for 3 packages now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update typespec-autorest to put response headers in lexicographic order
3 participants