Fix deployed playground #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/934/ |
timotheeguerin
requested review from
bterlson,
daviwil,
nguerrera,
markcowl and
allenjzhang
as code owners
daviwil
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #933
Also add UI testing running on
firefox(+ keep chrome).Tried enabling
webkit(safari) for the test too as playwright says it use some oss version of webkit but that doesn't seem to work. Maybe we can look into running the CI on osx as well and if then include safariUpdate playwright due to a breaking change in newer node microsoft/playwright#15717