Skip to content

Commit

Permalink
Don't use json module
Browse files Browse the repository at this point in the history
  • Loading branch information
lramos15 committed Aug 31, 2022
1 parent 5338ea8 commit 44fb93b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
5 changes: 2 additions & 3 deletions src/common/baseTelemetryReporter.ts
Expand Up @@ -6,7 +6,6 @@ import type * as vscode from "vscode";
import type { TelemetryEventMeasurements, TelemetryEventProperties, RawTelemetryEventProperties } from "../../dist/telemetryReporter";
import { ITelemetryAppender } from "./baseTelemetryAppender";
import { TelemetryLevel, TelemetryUtil } from "./util";
import { version } from "../../package.json";

export interface AppenderData {
properties?: RawTelemetryEventProperties,
Expand Down Expand Up @@ -157,8 +156,8 @@ export class BaseTelemetryReporter {
commonProperties["common.platformversion"] = (this.osShim.release || "").replace(/^(\d+)(\.\d+)?(\.\d+)?(.*)/, "$1$2$3");
commonProperties["common.extname"] = this.extensionId;
commonProperties["common.extversion"] = this.extensionVersion;
// Reads version from package.json
commonProperties["common.telemetryclientversion"] = version;
// TODO @lramos15, this should be dynamic but loading JSON modules didn't play nicely
commonProperties["common.telemetryclientversion"] = "0.6.3";
if (this.vscodeAPI && this.vscodeAPI.env) {
commonProperties["common.vscodemachineid"] = this.vscodeAPI.env.machineId;
commonProperties["common.vscodesessionid"] = this.vscodeAPI.env.sessionId;
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
Expand Up @@ -2,7 +2,6 @@
"compilerOptions": {
"noEmitOnError": false,
"strict": true,
"resolveJsonModule": true,
"target": "ES2020",
"module": "ES2020",
"esModuleInterop": true,
Expand Down

0 comments on commit 44fb93b

Please sign in to comment.