fix: fix type-casting warnings #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Mar 2, 2023
rzhao271
commented
Mar 2, 2023
rzhao271
commented
Mar 2, 2023
|
@rzhao271 can we rather upstream these fixes to https://github.com/TryGhost/node-sqlite3? We try to stay on top of their changes. |
|
👍 on upstreaming. |
rzhao271
force-pushed
the
rzhao271/binskim
branch
from
e552a32
to
a6204e8
Compare
|
The upstream PR is still open and has not been merged. I fixed the merge conflicts for that PR but I'm still waiting for a response. |
deepak1556
reviewed
Jun 14, 2023
Co-authored-by: Robo <hop2deep@gmail.com>
deepak1556
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.