Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only install bandit for python>=3.5 #14906

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Only install bandit for python>=3.5 #14906

merged 1 commit into from
Dec 7, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Dec 7, 2020 •
edited

The 3.5 comes from setup.py in bandit: PyCQA/bandit#615

@karrtikr karrtikr added the no-changelog No news entry required label Dec 7, 2020
@karrtikr karrtikr marked this pull request as ready for review December 7, 2020 23:20
ericsnowcurrently
ericsnowcurrently approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr karrtikr merged commit 447c74a into microsoft:main Dec 7, 2020
@karrtikr karrtikr deleted the bandit branch December 7, 2020 23:25
@karrtikr karrtikr removed the request for review from kimadeline December 7, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

@kimadeline kimadeline Awaiting requested review from kimadeline

Assignees

@karrtikr karrtikr

Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karrtikr @brettcannon @ericsnowcurrently