Fix npm security vulnerabilities #6831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Looks like the webpack is failing during the vsix compile. |
rchiodo
approved these changes
Aug 2, 2019
|
Yeah, logs show It's probably because 0.6.2 is explicitly required by @jupyterlab/rendermime and it has its own node_modules folder https://github.com/jupyterlab/jupyterlab/blob/master/packages/rendermime/package.json Until JupyterLab updates that dependency since this is a low severity vulnerability I can remove marked from our package.json? @rchiodo |
|
Wouldn't you have to actually add it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove react-data-grid-addons since we no longer need it.