Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reports stage in AzDO #8668

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Nov 19, 2019

For #8615

Disable Reports stage (so we can get an insiders build #8662 ) until I figure out what's broken when generating reports

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Nov 19, 2019
@kimadeline kimadeline marked this pull request as ready for review November 19, 2019 21:30
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #8668 into master will increase coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8668      +/-   ##
==========================================
+ Coverage   58.52%   59.18%   +0.65%     
==========================================
  Files         521      521              
  Lines       23606    23977     +371     
  Branches     3868     3873       +5     
==========================================
+ Hits        13815    14190     +375     
+ Misses       8874     8870       -4     
  Partials      917      917
Impacted Files Coverage Δ
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 100% <0%> (ø) ⬆️
src/client/common/variables/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/process/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/dotnet/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/linters/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0db721...53c2d01. Read the comment docs.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete it all.
We have git to bring back if required.

@kimadeline
Copy link
Author

Sure.

@kimadeline kimadeline merged commit 97d017c into microsoft:master Nov 19, 2019
@kimadeline kimadeline deleted the 8615-disable-coverage branch November 19, 2019 22:48
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the templates/jobs/coverage.yml file? Shouldn't we delete that too

greazer pushed a commit that referenced this pull request Nov 20, 2019
* Disable reports stage in AzDO
* delete reports stage
@kimadeline
Copy link
Author

I can delete it (or re-add build/ci/vscode-python-pr-validation.yaml) in my other coverage PR #8663 .

@kimadeline
Copy link
Author

Nevermind @DonJayamanne, I forgot to disable coverage for all pipelines so I deleted templates/jobs/coverage.yml in #8683

@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants