Skip to content

Commit

Permalink
update native module deps
Browse files Browse the repository at this point in the history
  • Loading branch information
Deepak Mohan authored and deepak1556 committed May 16, 2019
1 parent 3b94ba3 commit 49f5b2d
Show file tree
Hide file tree
Showing 10 changed files with 1,882 additions and 1,760 deletions.
3 changes: 3 additions & 0 deletions build/lib/watch/package.json
Expand Up @@ -6,5 +6,8 @@
"private": true,
"devDependencies": {
"gulp-watch": "^4.3.9"
},

This comment has been minimized.

Copy link
@bpasero

bpasero May 25, 2019

Member

@deepak1556 is that because gulp-watch does not run with node 12 yet?

This comment has been minimized.

Copy link
@deepak1556

deepak1556 May 27, 2019

Contributor

yup, not just that the transitive dependencies of gulp-watch install a chokidar version that has older fsevents which wouldn't compile with node12. This forces to have a version we require.

"resolutions": {
"chokidar": "microsoft/chokidar#fsevents2"
}
}

0 comments on commit 49f5b2d

Please sign in to comment.