Revert "Revert "electron@4.2.3""

This reverts commit 513581e.
microsoft · Jun 4, 2019 · 97da4f4 · 97da4f4
1 parent dc543df
commit 97da4f4
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/.yarnrc b/.yarnrc
@@ -1,3 +1,3 @@
 disturl "https://atom.io/download/electron"
-target "4.2.2"
+target "4.2.3"
 runtime "electron"
diff --git a/cgmanifest.json b/cgmanifest.json
@@ -60,12 +60,12 @@
 				"git": {
 					"name": "electron",
 					"repositoryUrl": "https://github.com/electron/electron",
-					"commitHash": "b763d81d79755d7e1637193147588d32e41e796b"
+					"commitHash": "c1b5a1cfc8a14a337540193daecfa5d0f50dd7bb"
 				}
 			},
 			"isOnlyProductionDependency": true,
 			"license": "MIT",
-			"version": "4.2.2"
+			"version": "4.2.3"
 		},
 		{
 			"component": {

diff --git a/src/typings/electron.d.ts b/src/typings/electron.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for Electron 4.2.2
+// Type definitions for Electron 4.2.3
 // Project: http://electronjs.org/
 // Definitions by: The Electron Team <https://github.com/electron/electron>
 // Definitions: https://github.com/electron/electron-typescript-definitions
@@ -1341,13 +1341,13 @@ declare namespace Electron {
 		 * prevent the native window's title from changing.
 		 */
 		on(event: 'page-title-updated', listener: (event: Event,
-			title: string) => void): this;
+			title: string, explicitSet: boolean) => void): this;
 		once(event: 'page-title-updated', listener: (event: Event,
-			title: string) => void): this;
+			title: string, explicitSet: boolean) => void): this;
 		addListener(event: 'page-title-updated', listener: (event: Event,
-			title: string) => void): this;
+			title: string, explicitSet: boolean) => void): this;
 		removeListener(event: 'page-title-updated', listener: (event: Event,
-			title: string) => void): this;
+			title: string, explicitSet: boolean) => void): this;
 		/**
 		 * Emitted when the web page has been rendered (while not being shown) and window
 		 * can be displayed without a visual flash.

diff --git a/test/smoke/package.json b/test/smoke/package.json
@@ -22,7 +22,7 @@
     "@types/webdriverio": "4.6.1",
     "concurrently": "^3.5.1",
     "cpx": "^1.5.0",
-    "electron": "4.2.2",
+    "electron": "4.2.3",
     "htmlparser2": "^3.9.2",
     "mkdirp": "^0.5.1",
     "mocha": "^5.2.0",

diff --git a/test/smoke/yarn.lock b/test/smoke/yarn.lock
@@ -596,10 +596,10 @@ electron-download@^4.1.0:
     semver "^5.4.1"
     sumchecker "^2.0.2"
 
-electron@4.2.2:
-  version "4.2.2"
-  resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.2.tgz#e8720e68b2ef3dcf4ab721f9546cf436e08576d2"
-  integrity sha512-SNRr83kbsnNZU9AdYkAJZEW7UH9Q9Fvl0ynuKBXgFFulTX+Gkw5JATl2Tt4OQIKdCGUuBDaw+MEMXlaroNpceA==
+electron@4.2.3:
+  version "4.2.3"
+  resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.3.tgz#5d45da9dd5ae97269dbee2623840da808c72d29d"
+  integrity sha512-nx+jHxj2eNhaYHXFGdzr7zgSphpVHEU9WAu6qqEUsQ936X3c6bQ5Bdg08KbHZj+cyRRQ06JMu6/ILh5pWrDZaA==
   dependencies:
     "@types/node" "^10.12.18"
     electron-download "^4.1.0"