Skip to content

Commit

Permalink
remember view containers that aren't registered yet (#153150)
Browse files Browse the repository at this point in the history
fixes #149503

The comments panel was being registered later so by the time we went to
save it back to the cache, we thought were removing it. Then, once it
was registered, we would pin it since we thought it was new. Following,
the behavior of the activity bar, we save it back to the cache as is.
  • Loading branch information
sbatten committed Jun 27, 2022
1 parent 81113e2 commit a3ee1bf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/vs/workbench/browser/parts/panel/panelPart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,8 @@ export abstract class BasePanelPart extends CompositePart<PaneComposite> impleme
const viewContainerModel = this.viewDescriptorService.getViewContainerModel(viewContainer);
state.push({ id: compositeItem.id, name: viewContainerModel.title, pinned: compositeItem.pinned, order: compositeItem.order, visible: compositeItem.visible });
placeholders.push({ id: compositeItem.id, name: this.getCompositeActions(compositeItem.id).activityAction.label });
} else {
state.push({ id: compositeItem.id, name: compositeItem.name, pinned: compositeItem.pinned, order: compositeItem.order, visible: compositeItem.visible });
}
}

Expand Down

0 comments on commit a3ee1bf

Please sign in to comment.