Don't return trigger characters for ambient JS suggestions #130727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130096
JS files include their own version of word based suggestions. These include every symbol name in the current file (even if the symbol is not in scope).
These suggestions are incorrectly being returned in cases such as:
When you type
.
at the|
, TS likely should not be returning these suggestions (microsoft/TypeScript#45436) but this is not a recent regressionWhat changed however is that in 76885d7, I simplified our logic around commit characters to make it behave more consistently. In the spread cases above, this results in typing the second
.
committing the currently selected word based suggestionMy fix is to simply disable commit characters for the word based suggestions. This is how they behaved before 76885d7