electron - limit crash reporter to few insiders users #132961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
commented
Sep 13, 2021
| product.quality === 'insider' && // only for insiders | ||
| typeof crashReporterId === 'string' && // only if we have a crash reporter ID | ||
| uuidPattern.test(crashReporterId) && // only if the crash reporter ID is valid | ||
| crashReporterId.endsWith('0') // only if the crash reporter ID ends with `0` |
There was a problem hiding this comment.
This is a heuristic I picked, but maybe you have a better idea.
There was a problem hiding this comment.
@deepak1556 I ran some experiments generating 30000 UUIDs to roughly simulate our number of present insider users and typically end up with a number around ~1900 that match. Would you think that number if sufficient to find crashes?
bpasero
commented
Sep 13, 2021
| crashReporterStartOptions.uploadToServer = true; | ||
| const crashReporterDirectory = this._environmentService.crashReporterDirectory; | ||
| const crashReporterId = this._environmentService.crashReporterId; | ||
| if (crashReporterDirectory || crashReporterId) { |
There was a problem hiding this comment.
Now using these properties as a hint whether crash reporting is enabled at all.
This comment has been minimized.
This comment has been minimized.
deepak1556
requested changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #120902 by limiting the crash reporter to:
0