ci: unify artifacts processing on darwin #145226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
commented
Mar 16, 2022
|
Build to verify publishing https://monacotools.visualstudio.com/Monaco/_build/results?buildId=161309&view=results looks good. |
alexdima
approved these changes
Mar 16, 2022
tanhakabir
approved these changes
Mar 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #145053 (comment)
This renames our x64 server archives file name from
vscode-server-darwin.ziptovscode-server-darwin-x64.zip.Please note this does not change the asset id related with this artifact and continues to remain
server-darwin.Downstream consumer,
remote-sshextension seems to rely on the asset idhttps://update.code.visualstudio.com/commit:<sha>/server-darwinrather than the file name, so this change should not break the extension. @roblourens @tanhakabir can you please confirm ?