Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed commit hash, ref #13089 #155786

Merged
merged 3 commits into from Jul 21, 2022
Merged

Use fixed commit hash, ref #13089 #155786

merged 3 commits into from Jul 21, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jul 20, 2022

Ref #13089

Use a fixed commit hash to control when we want to update the ref to the upstream script.
Otherwise, we might get hit by that script updating and breaking our CI.

CC @Tyriar

TODO:

  • Custom Insiders build passes
  • Deb package is sane
  • PR is reviewed

@rzhao271 rzhao271 added this to the July 2022 milestone Jul 20, 2022
@rzhao271 rzhao271 requested a review from deepak1556 July 20, 2022 21:47
@rzhao271 rzhao271 self-assigned this Jul 20, 2022
@rzhao271
Copy link
Contributor Author

Did a small search.
https://github.com/electron/electron/tree/6165f6afc9af6f9ab4e32f4a7a8b0818f11e766a is the commit for 18.3.5.
The DEPS file shows the Chromium version is 100.0.4896.160.
It turns out we can use that version number directly.

@rzhao271
Copy link
Contributor Author

I manually verified that the dependencies list stayed the same, forgetting that the CI build checks that already 🤦‍♂️

@rzhao271 rzhao271 merged commit 9c413ba into main Jul 21, 2022
@rzhao271 rzhao271 deleted the rzhao271/deb-dependencies branch July 21, 2022 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants