[typescript-language-features] Add removeUnusedImports command
#161654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
Sep 26, 2022
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
|
Let’s wait for microsoft/TypeScript#50931 in case there are any changes requested from the TypeScript side. |
andrewbranch
commented
Sep 27, 2022
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Outdated
Show resolved
Hide resolved
|
@mjbvz I did quite a bit of reorganization to expose new command palette entries while reusing some of the code that already existed for the code actions on save. I tried it out and it seems to work, but I have a few questions I’ll leave inline, and let me know if you see anything that looks off. Thanks! |
andrewbranch
commented
Sep 30, 2022
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
mjbvz
requested changes
Oct 6, 2022
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
|
@andrewbranch Looks like the compile is failing. Can you take a look? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS counterpart: microsoft/TypeScript#50931