Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tslint to eslint migration #87644

Merged
merged 53 commits into from Jan 3, 2020
Merged

tslint to eslint migration #87644

Show file tree
Hide file tree
Changes from 51 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
556475c
add eslint-rules "module" and use it in eslintrc-file
jrieken Dec 24, 2019
ce0d705
add package.json script
jrieken Dec 24, 2019
31d049f
use (most of) generated eslintrc-file
jrieken Dec 24, 2019
21bc306
script run check JS and TS files
jrieken Dec 24, 2019
d0e72fe
ignore generated files
jrieken Dec 24, 2019
a104742
use single eslintrc-file for extensions/ and src/, no type check rules
jrieken Dec 24, 2019
c5e6c9a
Merge branch 'master' into joh/eslint-rules
jrieken Dec 24, 2019
0aa8604
Merge branch 'master' into joh/eslint-rules
jrieken Dec 30, 2019
1075b91
tweaks
jrieken Dec 30, 2019
b0d3805
use rulesdir instead of rules-module
jrieken Dec 30, 2019
9819da6
migrate import-patterns rule to eslint
jrieken Dec 30, 2019
291ee00
add no-buffer-ctor rule
jrieken Dec 30, 2019
a7ca3a5
rulesdir/rulePaths for gulp-eslint
jrieken Dec 30, 2019
54d2030
tweak rules and excludes
jrieken Dec 30, 2019
1dbc699
Merge branch 'master' into joh/eslint-rules
jrieken Dec 30, 2019
a3bd604
migrate translation remind rule
jrieken Dec 30, 2019
2ea9132
migrate no-nls-in-standalone-editor rule
jrieken Dec 30, 2019
b05b481
migrate no-standalone-editor rule
jrieken Dec 30, 2019
808865c
extract import path detection into util
jrieken Dec 30, 2019
11f9af0
check call expression argument length
jrieken Dec 30, 2019
4db8006
use ts-es-tree-typings, support import-equals
jrieken Dec 30, 2019
53d1dff
use AST selector to simplify things
jrieken Dec 30, 2019
a61f38e
migrate no-unexternalized-strings rule (have two variants)
jrieken Dec 30, 2019
c9179d1
fix nls-rule when using member-expression
jrieken Dec 30, 2019
9fefd2b
relax and allow double quoted strings appearing inside localize call
jrieken Dec 30, 2019
f885d77
remove unused dependency
jrieken Dec 31, 2019
e27d7ca
only one double-qoute string rule
jrieken Dec 31, 2019
600fded
correctly configure rule paths in hygiene task
jrieken Dec 31, 2019
f16368c
Merge branch 'master' into joh/eslint-rules
jrieken Dec 31, 2019
dc84c71
update 'gulp eslint' and 'gulp hygiene' so that eslint also seens TS …
jrieken Dec 31, 2019
2bd1595
tweak ignore file
jrieken Dec 31, 2019
50d16a3
add rulePaths-option for eslint extension
jrieken Dec 31, 2019
324764a
cleanup rule meta data, add links when possible
jrieken Dec 31, 2019
e6d9b41
makes eslint fail the hygiene checks
jrieken Dec 31, 2019
e22be57
add disabled rules for being more complete with our tslint config...
jrieken Dec 31, 2019
d8b6b05
Merge branch 'master' into joh/eslint-rules
jrieken Jan 2, 2020
ee4dccd
disable tslint in hygiene check
jrieken Jan 2, 2020
856d085
run "eslint --fix" to get some changes for free
jrieken Jan 2, 2020
90512e6
tslint default severity is OFF
jrieken Jan 2, 2020
f80a6f9
update rule-disablements (eslint-disable for tslint-disable)
jrieken Jan 2, 2020
84013e2
fix double quote issues
jrieken Jan 2, 2020
2141437
fix eslint issues in build/gulpfile.*
jrieken Jan 2, 2020
80e6e42
adjust rule to allow double quotes for "use strict" and other directives
jrieken Jan 2, 2020
2a71a96
also disable tslint for build-folder
jrieken Jan 2, 2020
d18119e
enable jsdoc/no-types rule for TS files
jrieken Jan 2, 2020
12eb715
(re)enable no-extra-semi rule
jrieken Jan 2, 2020
769bbe2
remove tslint.json files
jrieken Jan 3, 2020
09ee89c
remove more unused tslint directives
jrieken Jan 3, 2020
37b071f
remove custom tslint rules
jrieken Jan 3, 2020
ca8a717
tslint removal
jrieken Jan 3, 2020
125ba4a
enable custom/forked no-unused-expressions rule
jrieken Jan 3, 2020
1864915
add eslint task definition
jrieken Jan 3, 2020
874a037
Merge branch 'master' into joh/eslint-rules
jrieken Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions .eslintignore
View file
Open in desktop
@@ -0,0 +1,16 @@
**/vs/nls.build.js
**/vs/nls.js
**/vs/css.build.js
**/vs/css.js
**/vs/loader.js
**/promise-polyfill/**
**/insane/**
**/marked/**
**/test/**/*.js
**/node_modules/**
**/vscode-api-tests/testWorkspace/**
**/vscode-api-tests/testWorkspace2/**
**/extensions/**/out/**
**/extensions/**/build/**
**/extensions/markdown-language-features/media/**
**/extensions/typescript-basics/test/colorize-fixtures/**