Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to use UnsafeCell #1517

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Update tests to use UnsafeCell #1517

merged 1 commit into from
Feb 8, 2022

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Feb 8, 2022 •
edited

Fixes #1515

rpjohnst
rpjohnst approved these changes Feb 8, 2022
View reviewed changes
Copy link

@rpjohnst rpjohnst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me- IIUC this fixes the immediate UB (of course without addressing concurrency).

@kennykerr kennykerr merged commit c7cbaaa into master Feb 8, 2022
@kennykerr kennykerr deleted the unsound branch February 8, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpjohnst rpjohnst rpjohnst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tests to use UnsafeCell
2 participants
@kennykerr @rpjohnst