-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Win32 array parameters #1562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@damyanp could you look over the DirectX APIs - many changes there - they look good to me, but I'd appreciate another pair of eyes. It's a lot easier with CodeFlow. 😉 |
This was referenced Feb 23, 2022
damyanp
reviewed
Feb 24, 2022
crates/libs/windows/src/Windows/Win32/Graphics/Direct3D12/mod.rs
Outdated
Show resolved
Hide resolved
damyanp
reviewed
Feb 24, 2022
crates/libs/windows/src/Windows/Win32/Graphics/Direct3D12/mod.rs
Outdated
Show resolved
Hide resolved
damyanp
reviewed
Feb 24, 2022
damyanp
reviewed
Feb 24, 2022
crates/libs/windows/src/Windows/Win32/Graphics/Direct3D12/mod.rs
Outdated
Show resolved
Hide resolved
This was referenced Mar 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for both relative and fixed size Win32 array parameters.
Here's an example of an API with a fixed-size array parameter:
Previously, the last parameter was merely a pointer and could not check whether the buffer was large enough. Now the size is checked at compile time.
And here is an example of an API with a relative array parameter:
Previously, both input and output buffers consisted of a pair of parameters for each pointer and length. Now, a pair of slices is expected and the underlying argument pairs are derived from those.
Fixes #1339
Fixes #972
Fixes #790
Fixes #479