Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: expose Interface trait and Weak object in documentation #1576

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

vthib
Copy link
Contributor

@vthib vthib commented Mar 2, 2022

The Interface trait exposes two public functions that are quite useful
when using COM objects.

The Weak struct is also returned by the downgrade function, so expose it
as well.

Closes #1502

@ghost
Copy link

ghost commented Mar 2, 2022

CLA assistant check
All CLA requirements met.

@kennykerr
Copy link
Collaborator

Did you test this locally?

cargo doc -p windows --open

@vthib
Copy link
Contributor Author

vthib commented Mar 4, 2022

Yes I did, it looks fine. The build issues are afaict not linked to my PR

@kennykerr
Copy link
Collaborator

OK, will investigate.

@kennykerr
Copy link
Collaborator

Fixed in #1580 - then I'll rerun this build.

@kennykerr
Copy link
Collaborator

@vthib this issue has now been fixed but I can't seem to update your branch to take the fix - if you can merge master we should be good to go.

The Interface trait exposes two public functions that are quite useful
when using COM objects.
The Weak struct is also returned by the downgrade function, so expose it
as well.
@vthib vthib force-pushed the expose-interface-weak-doc branch from e75d29c to 77d87fb Compare March 4, 2022 20:49
@vthib
Copy link
Contributor Author

vthib commented Mar 4, 2022

Thanks for the fix, I rebased the PR

Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit 95dcbed into microsoft:master Mar 5, 2022
@kennykerr kennykerr mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose cast method in docs and update documentation on Interface trait
2 participants